Skip to content

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Sep 5, 2023

Summary of Changes

Transforming TinyMCE to use EditorProvider and onEditorSetup event.
Basicaly just renaming a couple of methods, and variables rearange.

Testing Instructions

Apply patch.
Use TinyMCE to edit an article.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, but better.

Link to documentations

Please select:

Reference:

@ceford
Copy link
Contributor

ceford commented Sep 8, 2023

I have tested this item ✅ successfully on cc86f3e

It works with the patch applied - but how do I know if it works better? I have only tested the Content / Article Text field - is that enough?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41599.

@HLeithner HLeithner merged commit 91ba3ee into joomla:5.0-dev Sep 10, 2023
@HLeithner
Copy link
Member

thanks

@HLeithner HLeithner added this to the Joomla! 5.0 milestone Sep 10, 2023
@Fedik Fedik deleted the tinymce-provider branch September 10, 2023 09:24
@Fedik Fedik mentioned this pull request Sep 12, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants