[5.0] Fix wrong language string constant used in database query of privacyconsent task scheduler plugin#41597
Merged
HLeithner merged 2 commits intojoomla:5.0-devfrom Sep 5, 2023
Conversation
4 tasks
richard67
changed the title
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for #40553 (comment) .
Summary of Changes
The new task scheduler plugin "plg_task_privacyconsent" added with PR #40553 queries the database to check for privacy consents for which a reminder should be sent or which are expired.
It uses an own language string key
PLG_TASK_PRIVACYCONSENT_SUBJECTfor the subject column of the#__privacy_consentstable in the WHERE condition.But the privacy consent system plugin which is still handling the non-cyclic functionality inserts the records with language string key
PLG_SYSTEM_PRIVACYCONSENT_SUBJECT.See also #40553 (comment) .
This is wrong.
The scheduler task should query for records with the
PLG_SYSTEM_PRIVACYCONSENT_SUBJECT.The language strings are not translated, only they keys are used, and string
PLG_TASK_PRIVACYCONSENT_SUBJECTis not used anywhere else.Testing Instructions
Code review.
Actual result BEFORE applying this Pull Request
Wrong language string key used in query.
Expected result AFTER applying this Pull Request
Right language string key used, and obsolete wrong key removed from the language file of the new scheduler task plugin.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed