Skip to content

[5.0] Fix undefined variables in scss#41567

Merged
HLeithner merged 2 commits intojoomla:5.0-devfrom
Fedik:scss-fixes1
Sep 3, 2023
Merged

[5.0] Fix undefined variables in scss#41567
HLeithner merged 2 commits intojoomla:5.0-devfrom
Fedik:scss-fixes1

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Sep 3, 2023

Pull Request for Issue # .

Summary of Changes

Fix undefined variables in scss after

Testing Instructions

run npm install

Actual result BEFORE applying this Pull Request

npm fail with error

Expected result AFTER applying this Pull Request

npm runs

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Sep 3, 2023
@Fedik Fedik mentioned this pull request Sep 3, 2023
4 tasks
@richard67
Copy link
Member

I have tested this item ✅ successfully on 8d668c5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41567.

@Fedik
Copy link
Member Author

Fedik commented Sep 3, 2023

I not very understood why it require extra import, but it seems helps.

@HLeithner HLeithner merged commit 1919ca5 into joomla:5.0-dev Sep 3, 2023
@Fedik Fedik deleted the scss-fixes1 branch September 3, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants