Skip to content

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Sep 3, 2023

Pull Request for Issue #41530 (comment) .

Summary of Changes

It should the also be removed from the list of core extensions in the ExtensionsHelper

Testing Instructions

update from 4.4 to 5.0 nightly and check core extensions
image

Actual result BEFORE applying this Pull Request

captcha plugin(s) are still listed as core extension

Expected result AFTER applying this Pull Request

captcha plugins are no longer listed as core extension

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

I have tested this item ✅ successfully on a6d3a4e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41563.

@ChristineWk
Copy link

After installation of a clean Joomla 4.4 & Patchtester I had both captchas.

After update to 5.0.0-beta1-dev the result is now:
recaptcha is uninstalled,
invisible one is unlocked
Is that correct?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41563.

@heelc29
Copy link
Contributor Author

heelc29 commented Sep 3, 2023

Is that correct?

Yes

@richard67
Copy link
Member

Is that correct?

Yes

Yes

@ChristineWk
Copy link

ChristineWk commented Sep 3, 2023

then it's OK. I thought both should gone.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41563.

@ChristineWk
Copy link

I have tested this item ✅ successfully on a6d3a4e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41563.

@Quy
Copy link
Contributor

Quy commented Sep 3, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41563.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 3, 2023
@richard67 richard67 added the Small A PR which only has a small change label Sep 3, 2023
@HLeithner HLeithner merged commit c527d07 into joomla:5.0-dev Sep 4, 2023
@HLeithner
Copy link
Member

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 4, 2023
@heelc29 heelc29 deleted the 5.0/core-extensions/captcha branch September 10, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Small A PR which only has a small change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants