[5.0] fix path build_incomplete#41562
Merged
HLeithner merged 2 commits intojoomla:5.0-devfrom Sep 3, 2023
Merged
Conversation
dgrammatiko
approved these changes
Sep 3, 2023
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
change start directory from
JPATH_BASEtoJPATH_ROOTforbuild_incomplete.htmlfor reference see #40509 @dgrammatiko
Testing Instructions
checkout this repo (without install composer/npm)
[DOMAIN]/index.php[DOMAIN]/installation/index.php[DOMAIN]/administrator/index.phpActual result BEFORE applying this Pull Request
when visit
[DOMAIN]/administrator/index.phpfollowing warning appears:Warning: file_get_contents(/administrator/templates/system/build_incomplete.html): Failed to open stream: No such file or directory in /administrator/includes/app.php on line 31Expected result AFTER applying this Pull Request
always show error page
build_incompleteLink to documentations
Please select: