Skip to content

Comments

system test com_modules webservices#41560

Merged
laoneo merged 20 commits intojoomla:4.4-devfrom
alikon:patch-12
Sep 9, 2023
Merged

system test com_modules webservices#41560
laoneo merged 20 commits intojoomla:4.4-devfrom
alikon:patch-12

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Sep 3, 2023

Summary of Changes

API tests for following endpoints:

  • GET: /api/index.php/v1/modules/types/administrator
  • GET: /api/index.php/v1/modules/types/site
  • GET: /api/index.php/v1/modules/site
  • GET: /api/index.php/v1/modules/site{module_id}
  • GET: /api/index.php/v1/modules/administrator
  • GET: /api/index.php/v1/modules/administrator{module_id}
  • POST: /api/index.php/v1/modules/site
  • PATCH: /api/index.php/v1/modules/site{module_id}
  • DELETE: /api/index.php/v1/modules/site{module_id}

@alikon alikon marked this pull request as ready for review September 5, 2023 17:57
@laoneo
Copy link
Member

laoneo commented Sep 6, 2023

Can you rename the file to Site.cy.js and move the administrator test into a new file Administrator.cy.js, then the same with types? Like that it has the same pattern as the other tests, where the file name is the name of the second segment of the tests. Thanks.

@laoneo laoneo self-assigned this Sep 6, 2023
@laoneo laoneo added this to the Joomla! 4.4.0 milestone Sep 6, 2023
@alikon alikon marked this pull request as draft September 6, 2023 17:10
@laoneo
Copy link
Member

laoneo commented Sep 9, 2023

If the pr is ready, please remove the draft status.

@alikon alikon marked this pull request as ready for review September 9, 2023 15:36
@laoneo laoneo merged commit 3ba9cff into joomla:4.4-dev Sep 9, 2023
@laoneo
Copy link
Member

laoneo commented Sep 9, 2023

Thanks!

@alikon alikon deleted the patch-12 branch September 10, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants