Skip to content

[5.0][Events] More Finder event classes#41510

Merged
HLeithner merged 1 commit intojoomla:5.0-devfrom
Fedik:finder-events3
Aug 29, 2023
Merged

[5.0][Events] More Finder event classes#41510
HLeithner merged 1 commit intojoomla:5.0-devfrom
Fedik:finder-events3

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Aug 29, 2023

Summary of Changes

Missing classes for Finder

Affected events:

  • onStartIndex
  • onBeforeIndex
  • onBuildIndex
  • onFinderGarbageCollection

Currently the events are empty, in the future we can provide an Indexer and State instances with each event, instead of accessing them staticaly. Example $iState = Indexer::getState() may become $iState = $event->getState()

Testing Instructions

Use Smart search index

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

Reference:

@Fedik Fedik added the Feature label Aug 29, 2023
@HLeithner HLeithner merged commit 1a3000a into joomla:5.0-dev Aug 29, 2023
@HLeithner
Copy link
Member

thanks @Hackwar can you check

@Fedik Fedik deleted the finder-events3 branch August 29, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants