Skip to content

Comments

[4.x] Remove punctuation marks Remember username E-mail#41503

Merged
obuisard merged 5 commits intojoomla:4.3-devfrom
tecpromotion:patch-2
Sep 4, 2023
Merged

[4.x] Remove punctuation marks Remember username E-mail#41503
obuisard merged 5 commits intojoomla:4.3-devfrom
tecpromotion:patch-2

Conversation

@tecpromotion
Copy link
Contributor

Summary of Changes

There was a request in a local translation to remove the dot at the end. Users would understand the dot as part of the username and this leads to confusion.

Testing Instructions

.

Actual result BEFORE applying this Pull Request

COM_USERS_EMAIL_USERNAME_REMINDER_BODY="Hello,\n\nA username reminder has been requested for your {SITENAME} account.\n\nYour username is {USERNAME}.\n\nTo login to your account, select the link below.\n\n{LINK_TEXT} \n\nThank you."

Expected result AFTER applying this Pull Request

COM_USERS_EMAIL_USERNAME_REMINDER_BODY="Hello,\n\nA username reminder has been requested for your {SITENAME} account.\n\nYour username is {USERNAME}\n\nTo login to your account, select the link below.\n\n{LINK_TEXT} \n\nThank you."

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.3-dev labels Aug 28, 2023
@heelc29
Copy link
Contributor

heelc29 commented Aug 29, 2023

I have tested this item ✅ successfully on 6586594


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41503.

@Quy
Copy link
Contributor

Quy commented Aug 29, 2023

I have tested this item ✅ successfully on 6586594


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41503.

@heelc29
Copy link
Contributor

heelc29 commented Sep 3, 2023

I have tested this item ✅ successfully on 0e80d7e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41503.

@Quy
Copy link
Contributor

Quy commented Sep 3, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41503.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 3, 2023
@obuisard obuisard added this to the Joomla! 4.3.5 milestone Sep 4, 2023
@obuisard obuisard merged commit 8ab9fd8 into joomla:4.3-dev Sep 4, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 4, 2023
@obuisard
Copy link
Contributor

obuisard commented Sep 4, 2023

Thank you Stefan @tecpromotion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants