[4.x] Remove punctuation marks Remember username E-mail#41503
Merged
obuisard merged 5 commits intojoomla:4.3-devfrom Sep 4, 2023
Merged
[4.x] Remove punctuation marks Remember username E-mail#41503obuisard merged 5 commits intojoomla:4.3-devfrom
obuisard merged 5 commits intojoomla:4.3-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 6586594 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41503. |
Quy
reviewed
Aug 29, 2023
tecpromotion
commented
Aug 29, 2023
Contributor
|
I have tested this item ✅ successfully on 6586594 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41503. |
Contributor
|
I have tested this item ✅ successfully on 0e80d7e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41503. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41503. |
Contributor
|
Thank you Stefan @tecpromotion! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
There was a request in a local translation to remove the dot at the end. Users would understand the dot as part of the username and this leads to confusion.
Testing Instructions
.
Actual result BEFORE applying this Pull Request
COM_USERS_EMAIL_USERNAME_REMINDER_BODY="Hello,\n\nA username reminder has been requested for your {SITENAME} account.\n\nYour username is {USERNAME}.\n\nTo login to your account, select the link below.\n\n{LINK_TEXT} \n\nThank you."
Expected result AFTER applying this Pull Request
COM_USERS_EMAIL_USERNAME_REMINDER_BODY="Hello,\n\nA username reminder has been requested for your {SITENAME} account.\n\nYour username is {USERNAME}\n\nTo login to your account, select the link below.\n\n{LINK_TEXT} \n\nThank you."
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed