Skip to content

[5.0][Events] Privacy event classes#41486

Merged
HLeithner merged 12 commits intojoomla:5.0-devfrom
Fedik:event-privacy
Sep 2, 2023
Merged

[5.0][Events] Privacy event classes#41486
HLeithner merged 12 commits intojoomla:5.0-devfrom
Fedik:event-privacy

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Aug 27, 2023

Summary of Changes

Implementing Event classes for Privacy events.

Affected events:

  • onPrivacyCollectAdminCapabilities
  • onPrivacyCheckPrivacyPolicyPublished
  • onPrivacyExportRequest
  • onPrivacyCanRemoveData
  • onPrivacyRemoveData

Testing Instructions

Use Privacy features, export request, delete reques, capabilities overview

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

@Fedik Fedik marked this pull request as draft August 27, 2023 12:30
@Fedik Fedik added the Feature label Aug 27, 2023
@Fedik Fedik marked this pull request as ready for review August 27, 2023 13:29
@richard67 richard67 changed the title [5.0][Events] Privacy event calsses [5.0][Events] Privacy event classes Aug 30, 2023
@HLeithner
Copy link
Member

please resolve conflict


Factory::getApplication()->triggerEvent('onPrivacyCheckPrivacyPolicyPublished', [&$policy]);
PluginHelper::importPlugin('privacy', null, true, $dispatcher);
PluginHelper::importPlugin('user', null, true, $dispatcher);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for later, have we a chance to deprecate this? if or if not can you add this to the migration documentation to not use "user" plugins for privacy stuff so we can remove this import here in Joomla 7.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I not sure what a reason for these imports, But I think we can just add deprecation here. It is our module.
And 'user' group should be already imported, while login.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has a description 2 lines above that's it's b/c for < 3.9 ;-)

I'm not sure if we always import user plugins for each page load?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmhm, probably not, I thought it always up with onUserAuthorisation,
but not sure currently

@HLeithner HLeithner merged commit f5464e2 into joomla:5.0-dev Sep 2, 2023
@HLeithner
Copy link
Member

Merging this as with code review and based on the other similar PRs, before beta1 to get enough feedback for final release.

@Fedik Fedik deleted the event-privacy branch September 2, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants