[5.0][Events] Privacy event classes#41486
Conversation
|
please resolve conflict |
Conflicts: libraries/src/Event/CoreEventAware.php
|
|
||
| Factory::getApplication()->triggerEvent('onPrivacyCheckPrivacyPolicyPublished', [&$policy]); | ||
| PluginHelper::importPlugin('privacy', null, true, $dispatcher); | ||
| PluginHelper::importPlugin('user', null, true, $dispatcher); |
There was a problem hiding this comment.
for later, have we a chance to deprecate this? if or if not can you add this to the migration documentation to not use "user" plugins for privacy stuff so we can remove this import here in Joomla 7.0
There was a problem hiding this comment.
I not sure what a reason for these imports, But I think we can just add deprecation here. It is our module.
And 'user' group should be already imported, while login.
There was a problem hiding this comment.
it has a description 2 lines above that's it's b/c for < 3.9 ;-)
I'm not sure if we always import user plugins for each page load?
There was a problem hiding this comment.
hmhm, probably not, I thought it always up with onUserAuthorisation,
but not sure currently
|
Merging this as with code review and based on the other similar PRs, before beta1 to get enough feedback for final release. |
Summary of Changes
Implementing Event classes for Privacy events.
Affected events:
Testing Instructions
Use Privacy features, export request, delete reques, capabilities overview
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select: