Skip to content

[4.4] Smart Search: Limiting highlighting of tokens #41463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MacJoom merged 10 commits into from
Sep 15, 2023
Merged

[4.4] Smart Search: Limiting highlighting of tokens #41463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b3fe8e9
Smart Search: Limiting highlighting of tokens
Hackwar Aug 26, 2023
191e612
Update components/com_finder/tmpl/search/default_results.php
Hackwar Aug 26, 2023
d7c9d8d
Merge branch '4.3-dev' into 4.3-finder-highlighter
QuyTon Sep 3, 2023
8c5e2b5
Merge branch '4.3-dev' into 4.3-finder-highlighter
obuisard Sep 7, 2023
61cb7e9
Merge branch '4.4-dev' into 4.3-finder-highlighter
obuisard Sep 11, 2023
b873918
Merge branch '4.4-dev' into 4.3-finder-highlighter
laoneo Sep 11, 2023
726e31d
Adding inline help text
Hackwar Sep 12, 2023
983b07d
Merge branch '4.3-finder-highlighter' of github.com:Hackwar/joomla-cm…
Hackwar Sep 12, 2023
edfb611
Merge branch '4.4-dev' into 4.3-finder-highlighter
Hackwar Sep 12, 2023
23e6dda
Merge branch '4.4-dev' into 4.3-finder-highlighter
MacJoom Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions administrator/components/com_finder/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@
name="highlight_terms"
type="radio"
label="COM_FINDER_CONFIG_HILIGHT_CONTENT_SEARCH_TERMS_LABEL"
description="COM_FINDER_CONFIG_HIGHLIGHT_CONTENT_SEARCH_TERMS_DESC"
layout="joomla.form.field.radio.switcher"
default="1"
>
Expand Down
1 change: 1 addition & 0 deletions administrator/language/en-GB/com_finder.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ COM_FINDER_CONFIG_FIELD_OPENSEARCH_NAME_LABEL="OpenSearch Name"
COM_FINDER_CONFIG_FILTER_COMMONWORDS_LABEL="Filter Common Words"
COM_FINDER_CONFIG_FILTER_NUMERICS_LABEL="Filter Numeric Terms"
COM_FINDER_CONFIG_GATHER_SEARCH_STATISTICS_LABEL="Gather Search Statistics"
COM_FINDER_CONFIG_HIGHLIGHT_CONTENT_SEARCH_TERMS_DESC="For performance reasons, this will not highlight more than 10 different terms in the search results."
COM_FINDER_CONFIG_HILIGHT_CONTENT_SEARCH_TERMS_LABEL="Highlight Search Terms"
COM_FINDER_CONFIG_IMAGE_CLASS_LABEL="Image Class"
COM_FINDER_CONFIG_LANGUAGE_DEFAULT_DEFAULT_LANGUAGE="Default Site Language"
Expand Down
3 changes: 2 additions & 1 deletion components/com_finder/tmpl/search/default_results.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,13 @@
<?php // Activate the highlighter if enabled. ?>
<?php if (!empty($this->query->highlight) && $this->params->get('highlight_terms', 1)) : ?>
<?php
// Allow a maximum of 10 tokens to be highlighted. Otherwise the URL can get too long.
$this->document->getWebAssetManager()->useScript('highlight');
$this->document->addScriptOptions(
'highlight',
[[
'class' => 'js-highlight',
'highLight' => $this->query->highlight,
'highLight' => array_slice($this->query->highlight, 0, 10),
]]
);
?>
Expand Down