[5.0] Use Joomla dialog for confirmation dialog, instead of old school confirm()#41434
Merged
HLeithner merged 17 commits intojoomla:5.0-devfrom Sep 4, 2023
Merged
[5.0] Use Joomla dialog for confirmation dialog, instead of old school confirm()#41434HLeithner merged 17 commits intojoomla:5.0-devfrom
HLeithner merged 17 commits intojoomla:5.0-devfrom
Conversation
Member
Contributor
|
I have tested this item ✅ successfully on ee1e199 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41434. |
Contributor
|
I have tested this item 🔴 unsuccessfully on ee1e199 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41434. |
Contributor
Member
Author
Yeap, I did not checked, but I think cypress expecting old confirm() |
Member
Author
|
Test can be fixed only after updating Firefox for Cypress |
Member
Test running now with
|
Member
Author
|
After removing failed tests it is working now. |
Member
|
thanks |
Member
|
I think we need a migration documentation? |
Contributor
yes please as there are other places we can use this |
Member
Author
|
It is part of Or need something more specific? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary of Changes
Use Joomla dialog for confirmation dialog, instead of old school confirm()
Also an example how it could be used in other places.
Testing Instructions
Apply patch, run
npm install.Trash some Article, and then try empty the trash.
Actual result BEFORE applying this Pull Request
You get old school confirm() dialog
Expected result AFTER applying this Pull Request
You get Joomla dialog
Link to documentations
Please select:
Reference: