Skip to content

[5.0] Update incompatible.html#41422

Closed
heelc29 wants to merge 1 commit intojoomla:5.0-devfrom
heelc29:5.0/template-incompatible
Closed

[5.0] Update incompatible.html#41422
heelc29 wants to merge 1 commit intojoomla:5.0-devfrom
heelc29:5.0/template-incompatible

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Aug 21, 2023

Summary of Changes

update includes/incompatible.html

file was not updated with #41410; since #40509 (comment) there is a new file

please take care of it in the next upmerge (after translation update) @HLeithner @laoneo

Testing Instructions

run npm ci

Actual result BEFORE applying this Pull Request

1 versioned file is modified

Expected result AFTER applying this Pull Request

no file is modified

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

don't the build scripts automatically handle these?

@heelc29
Copy link
Contributor Author

heelc29 commented Aug 21, 2023

don't the build scripts automatically handle these?

Yes, but not with an upmerge because the file do not exist in 4.4-dev

@heelc29 heelc29 mentioned this pull request Aug 21, 2023
@richard67
Copy link
Member

I have tested this item ✅ successfully on eb198cb

Hint for other testers:

  • You can fetch the changes from this PR with git commands git fetch upstream pull/41422/head:test-pr-41422 and then git checkout test-pr-41422.
  • After composer install and npm ci, use git command git status to see if there are some changes to be committed.
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41422.

@HLeithner
Copy link
Member

I'm closing this, it will be automatically be done with language update. thanks anyway.

@HLeithner HLeithner closed this Aug 22, 2023
@heelc29 heelc29 deleted the 5.0/template-incompatible branch August 22, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants