Skip to content

Comments

[4] webservice categories add description field#41307

Merged
obuisard merged 5 commits intojoomla:4.3-devfrom
alikon:patch-4
Aug 13, 2023
Merged

[4] webservice categories add description field#41307
obuisard merged 5 commits intojoomla:4.3-devfrom
alikon:patch-4

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Aug 2, 2023

Pull Request for Issue #41291

Summary of Changes

return the description field

Testing Instructions

Do an API call and set the category description:

Actual result BEFORE applying this Pull Request

the description field is not returned

Expected result AFTER applying this Pull Request

the description field is present

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon changed the title add description field [4] webservice categories add description field Aug 2, 2023
@alikon alikon marked this pull request as ready for review August 2, 2023 08:18
@Razzo1987
Copy link
Contributor

Razzo1987 commented Aug 3, 2023

I have tested this item ✅ successfully on 2970686

GET: content/categories
image

POST: content/categories
image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41307.

@Quy
Copy link
Contributor

Quy commented Aug 3, 2023

I have tested this item ✅ successfully on 2970686


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41307.

@Quy Quy removed the Webservices label Aug 3, 2023
@Quy
Copy link
Contributor

Quy commented Aug 3, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41307.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 3, 2023
@laoneo
Copy link
Member

laoneo commented Aug 3, 2023

Can you rebase this to 4.4 and add a system test?

@obuisard obuisard added this to the Joomla! 4.3.4 milestone Aug 3, 2023
@obuisard obuisard removed this from the Joomla! 4.3.4 milestone Aug 3, 2023
@alikon alikon changed the base branch from 4.3-dev to 4.4-dev August 6, 2023 10:06
@alikon
Copy link
Contributor Author

alikon commented Aug 6, 2023

@alikon
Copy link
Contributor Author

alikon commented Aug 6, 2023

wrong rebase i'll switch it back to 4.3

@alikon alikon changed the base branch from 4.4-dev to 4.3-dev August 6, 2023 11:16
@obuisard obuisard added this to the Joomla! 4.3.4 milestone Aug 13, 2023
@obuisard obuisard merged commit 36ff575 into joomla:4.3-dev Aug 13, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 13, 2023
@obuisard
Copy link
Contributor

Thank you Nicola @alikon for the PR.

@laoneo
Copy link
Member

laoneo commented Aug 13, 2023

rebased to 4.4 aren't system test already there https://github.com/joomla/joomla-cms/blame/4.3-dev/tests/Codeception/api/com_content/ContentCest.php#L97 ?

In 4.4 we do the system tests on cypress here.

@obuisard
Copy link
Contributor

I am reverting, will re-create it for 4.4. I apologize @alikon, I will link the new PR to this one.

obuisard added a commit that referenced this pull request Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants