Skip to content

Conversation

@sakiss
Copy link
Contributor

@sakiss sakiss commented Jul 25, 2023

Summary of Changes

This is a follow up to #35612.
Smart Search now shows images only for the articles in the results .

With this PR images for the contacts (com_contact) can be shown as well.

Testing Instructions

  1. You need to have some contacts created (under Components > Contacts > Contacts).
    Your contacts need to have images.

  2. Go to the Smart Search and press the "Index" button.

  3. In the menu item for the Smart Search enable the setting Result Image .

  4. Now in the front-end use the Smart Search (menu item or module) and search for one of your contacts.

Actual result BEFORE applying this Pull Request

No image in the contact results.

Expected result AFTER applying this Pull Request

Contact images.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@HLeithner
Copy link
Member

pretty sure this have to go into 5.0

@sakiss
Copy link
Contributor Author

sakiss commented Jul 26, 2023

@HLeithner it's an already shipped feature since 4.1. Just a continuation of it.

@HLeithner
Copy link
Member

It's not a bugfix so it's a new feature and new features go into the next minor version, since 4.4 is only a preparation release for 5.0 it has to go directly to 5.0.

We try to be more strict with changing code in bugfix releases to have more stable releases with no/less regressions.

@sakiss
Copy link
Contributor Author

sakiss commented Jul 26, 2023

How it's a new feature?
The images for the finder results were shipped back in J4.1 (see: #35612)
But were not complete.

I leave that to the RL decision

@obuisard
Copy link
Contributor

Thank you very much for the PR Sakis @sakiss.
We have discussed the PR in our latest maintenance meeting and consider this as an improvement that can only be included into a 'feature' release. I will rebase the PR to 5.0.

@obuisard obuisard changed the base branch from 4.3-dev to 5.0-dev July 26, 2023 17:59
@sakiss sakiss changed the title Smart Search to show Contact images [5.0] Smart Search to show Contact images Aug 15, 2023
@Quy
Copy link
Contributor

Quy commented Aug 16, 2023

I have tested this item ✅ successfully on 27b3efd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41236.

@HLeithner HLeithner merged commit a76dae6 into joomla:5.0-dev Aug 22, 2023
@HLeithner
Copy link
Member

thanks

@sakiss sakiss deleted the finder_contact_images branch August 22, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants