[5.0] b/c plugin - Load class aliases earlier and move es5 assets

[HLeithner]

This PR moves the class alias loading to the constructor function of the plugin to load the alias at the earliest possible execution point.

Additional this PR moves all es5 assets from all joomla.asset.json into the es5.asset.json and make loading them optional.

Summary of Changes

• Move class aliasing to the constructor
• Move es5 webassets to the plugin

Testing Instructions

Full CMS with and without plugin active

Actual result BEFORE applying this Pull Request

Should work

Expected result AFTER applying this Pull Request

Should still work

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[HLeithner]

Do you have anything to say @SharkyKZ or would you only like to spread bad vibes?

[brianteeman]

Should this string be less technical and geeky?

[brianteeman]

Perhaps explaining when/why you might need to enable it

[HLeithner]

I thought about it and I didn't came to a better text, in the end you have to understand what es5 javascript files are... so it's more a template developer setting and not really for end user useful. But I'm happy about a better description

[brianteeman]

Maybe something along the lines of "This should be enabled if you get an error message saying ..."

[brianteeman]

I see that there are still es5 references in
administrator\templates\atum\joomla.asset.json
build\media_source\com_joomlaupdate\joomla.asset.json
build\media_source\plg_system_jooa11y\joomla.asset.json

[HLeithner]

I see that there are still es5 references in administrator\templates\atum\joomla.asset.json build\media_source\com_joomlaupdate\joomla.asset.json build\media_source\plg_system_jooa11y\joomla.asset.json

Thanks, don't know why my initial search didn't found the 3 assets.... in the build folder... the template I didn't checked tbh

[brianteeman]

I just grepped for es5 in all joomla.asset.json files

[brianteeman]

Does this need changing as well

joomla-cms/build/build-modules-js/settings.json

Lines 77 to 87 in e7e1fb4

	"name": "bootstrap.es5",
	"type": "script",
	"deprecated": true,
	"uri": "",
	"dependencies": [
	"core"
	],
	"attributes": {
	"nomodule": true,
	"defer": true
	}

[HLeithner]

Does this need changing as well

joomla-cms/build/build-modules-js/settings.json

Lines 77 to 87 in e7e1fb4

	"name": "bootstrap.es5",
	"type": "script",
	"deprecated": true,
	"uri": "",
	"dependencies": [
	"core"
	],
	"attributes": {
	"nomodule": true,
	"defer": true
	}

I'm not sure I have seen it, @Fedik @dgrammatiko ?

[Fedik]

All what in settings will be in vendor/assets.json
When you added it in to the legacy.json, then remove it from settings.

[HLeithner]

thanks moved it to the plugin

[HLeithner]

Hopefully this solve all the JPlugin issues, merging it to get it into alpha3