[5.0] Add missing "/** CAN FAIL **/" to update SQL scripts from PR #38149

[richard67]

Pull Request for #38149 (comment) .

Summary of Changes

With PR #38149 , update SQL scripts have been added, which add a new column to a table.

However, the corresponding SQL statement is missing the /** CAN FAIL **/ installer hint, which has been implemented once with PR #36506 and established with PR #37156 for all ALTER TABLE ... ADD COLUMN statements.

The use of this installer hint is to ignore the SQL error which happens when the statement runs and the column already exists because MySQL and PostgreSQL do not support an IF NOT EXISTS in such an SQL statement. This can happen e.g. when an update breaks for some reason after the SQL statement has run but the schema version has not been updated in the database, so then trying to resume the broken update the statement will run again.

Testing Instructions

Code review. See e.g. following places for examples how /** CAN FAIL **/ is used:

• For MySQL/MariaDB
  https://github.com/joomla/joomla-cms/blob/4.4-dev/administrator/components/com_admin/sql/updates/mysql/4.3.2-2023-05-20.sql
• For PostgreSQL
  https://github.com/joomla/joomla-cms/blob/4.4-dev/administrator/components/com_admin/sql/updates/postgresql/4.3.2-2023-05-20.sql

Actual result BEFORE applying this Pull Request

Installer hint /** CAN FAIL **/ is missing.

Expected result AFTER applying this Pull Request

Installer hint /** CAN FAIL **/ is present.

Link to documentations

Please select:

• No documentation changes for docs.joomla.org needed

• No documentation changes for manual.joomla.org needed

[HLeithner]

thx

[brianteeman]

That was my fault for not understanding the meaning of CAN FAIL

[richard67]

That was fast 😄 .