[5.0] Fix SQL syntax error when updating on PotgsreSQL caused by PR #38149 #41177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
does that mean postgresql adds the column always to the end? |
Contributor
|
sorry about that |
Member
Author
@HLeithner Yes, and the same applies to other relational databases like Oracle, MS SQL Server, DB2, ... . Only MySQL and MariaDB support that. The order of columns in a table is absolutely irrelevant and so doesn't really matter. |
Member
|
only if you don't care about your structure ;-) ok thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for https://github.com/joomla/joomla-cms/pull/38149/files#r1265261563 .
Summary of Changes
PostgreSQL doesn't support "AFTER" in "ALTER TABLE ... ADD COLUMN ..." statements, see https://www.postgresql.org/docs/current/sql-altertable.html .
This pull request (PR) here fixes the wrong SQL statement added with PR #38149 .
Testing Instructions
Run the SQL statement changed by this PR on a PostgreSQL database with a 5.0-dev Joomla installation which doesn't have PR #38149 applied.
Actual result BEFORE applying this Pull Request
SQL syntax error.
Expected result AFTER applying this Pull Request
Column is added.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed