Skip to content

Comments

[4.3] The arrow-up icon of the Back-to-top Link should be visible on hovering.#41153

Closed
sandewt wants to merge 1 commit intojoomla:4.3-devfrom
sandewt:patch-6
Closed

[4.3] The arrow-up icon of the Back-to-top Link should be visible on hovering.#41153
sandewt wants to merge 1 commit intojoomla:4.3-devfrom
sandewt:patch-6

Conversation

@sandewt
Copy link
Contributor

@sandewt sandewt commented Jul 13, 2023

Pull Request for Issue # .

Summary of Changes

The arrow-up icon of the Back-to-top Link should be visible on hovering.
And in addition, the color of the button must then be blue.

Related to the Button text color issue #40435, that caused this problem.

Testing Instructions

Build npm ci.

Enable the Back-to-top Link button in Templates: Edit Style.

Hover on the Back-to-top button in the fontend of the site.

Code review

Actual result BEFORE applying this Pull Request

The arrow-up icon is NOT visible on hovering on the button.

Schermafbeelding 2023-07-13 115902

Expected result AFTER applying this Pull Request

The arrow-up icon is visible on hovering on the button.

Schermafbeelding 2023-07-13 120207

Link

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Background color on hover is vissible
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev labels Jul 13, 2023
@brianteeman
Copy link
Contributor

I cannot replicate the problem on j43 or j5

@sandewt
Copy link
Contributor Author

sandewt commented Jul 13, 2023

I cannot replicate the problem on j43

Clear the browser cache.

@brianteeman
Copy link
Contributor

How will clearing the browser cache have any impact on the site BEFORE applying this PR?

I have not applied the PR because I can not replicate the reported problem

@sandewt
Copy link
Contributor Author

sandewt commented Jul 13, 2023

How will clearing the browser cache have any impact on the site BEFORE applying this PR?

What is the result if you clear the browser history?

@brianteeman
Copy link
Contributor

it is the same of course

@sandewt
Copy link
Contributor Author

sandewt commented Jul 13, 2023

it is the same of course

I should have known better.

System information:
Windows 11, Firefox, MS Edge and Google Chrome.

@brianteeman
Copy link
Contributor

Found it and the reason why I couldnt replicate.

The problem is from your pull request #40435

As that hasnt been upmerged into 4.4 or 5 yet then I didnt have the faulty css

@obuisard
Copy link
Contributor

Not a fan of adding !important in the core, as it makes CSS overrides difficult down the road. Better complement #40435 to fix issues resulting from it.

@jackal-kr
Copy link

jackal-kr commented Aug 16, 2023

Hello,

I had a similar issue on my website after upgrading to 4.3.3 and had to roll-back to 4.3.2 because it broke the hover colors not only of the "Back-to-top Link" but of some other components as well. Took me a while to understand that was not me but the upgrade. Restored from backup to 4.3.2 and all was fixed. Simulated on my laptop and yes that was the culprit -> 4.3.3..

Any news when it will be fixed? Any workaround meanwhile?..

Thanks a lot!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41153.

@obuisard
Copy link
Contributor

The main issue comes from the fact that many button-like elements are actually not using the .btn class and that is where the confusion starts... So any 'a' element, styled as a button, but not having the .btn class will have a problem

@sandewt
Copy link
Contributor Author

sandewt commented Aug 26, 2023

See #40435 (comment)

@ChristineWk
Copy link

Issue confirmed (Back to top Link) but NPM Package is not available (404)

@sandewt sandewt marked this pull request as draft September 2, 2023 19:00
@sandewt
Copy link
Contributor Author

sandewt commented Sep 2, 2023

Issue confirmed (Back to top Link) but NPM Package is not available (404)

You can still download the package; or in the command-line interface run the npm ci command.

Anyway, I prefer the overall solution, which I have proposed here: #40435 (comment)
However, I am still waiting for a response(s).

@sandewt
Copy link
Contributor Author

sandewt commented Sep 14, 2023

Closed because PR #41749

@sandewt sandewt closed this Sep 14, 2023
@sandewt sandewt deleted the patch-6 branch August 19, 2024 13:50
@sandewt sandewt restored the patch-6 branch August 19, 2024 13:51
@sandewt sandewt deleted the patch-6 branch August 19, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants