Skip to content

[4.3] check of invalid json 'joomla.asset.json'#41135

Merged
obuisard merged 3 commits intojoomla:4.3-devfrom
heelc29:4.3/templates/joomla-asset
Jul 14, 2023
Merged

[4.3] check of invalid json 'joomla.asset.json'#41135
obuisard merged 3 commits intojoomla:4.3-devfrom
heelc29:4.3/templates/joomla-asset

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Jul 10, 2023

Summary of Changes

Validation of joomla.asset.json (JSON) is broken since J4.1 #35998 (child templates)

str_ends_with should covered by polyfill:

"symfony/polyfill-php80": "^1.16",

Testing Instructions

try to edit joomla.asset.json and save with an invalid json (eg. double comma)

Actual result BEFORE applying this Pull Request

file saved
image

site broken (here frontend cassiopeia)
image

Expected result AFTER applying this Pull Request

file not saved
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Jul 12, 2023

I have tested this item ✅ successfully on 5bf1e08


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41135.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Jul 13, 2023

I have tested this item ✅ successfully on 5bf1e08


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41135.

@alikon
Copy link
Contributor

alikon commented Jul 13, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41135.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 13, 2023
@obuisard obuisard added this to the Joomla! 4.3.4 milestone Jul 14, 2023
@obuisard obuisard merged commit e367bf8 into joomla:4.3-dev Jul 14, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 14, 2023
@obuisard
Copy link
Contributor

Thank you @heelc29 for the PR!

@heelc29 heelc29 deleted the 4.3/templates/joomla-asset branch July 23, 2023 21:53
GeraintEdwards pushed a commit to GeraintEdwards/joomla-cms that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants