[4.3] check of invalid json 'joomla.asset.json'#41135
Merged
obuisard merged 3 commits intojoomla:4.3-devfrom Jul 14, 2023
Merged
[4.3] check of invalid json 'joomla.asset.json'#41135obuisard merged 3 commits intojoomla:4.3-devfrom
obuisard merged 3 commits intojoomla:4.3-devfrom
Conversation
wilsonge
reviewed
Jul 12, 2023
Contributor
|
I have tested this item ✅ successfully on 5bf1e08 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41135. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 5bf1e08 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41135. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41135. |
Contributor
|
Thank you @heelc29 for the PR! |
GeraintEdwards
pushed a commit
to GeraintEdwards/joomla-cms
that referenced
this pull request
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Validation of
joomla.asset.json(JSON) is broken since J4.1 #35998 (child templates)str_ends_withshould covered by polyfill:joomla-cms/composer.json
Line 84 in c944137
Testing Instructions
try to edit
joomla.asset.jsonand save with an invalid json (eg. double comma)Actual result BEFORE applying this Pull Request
file saved

site broken (here frontend cassiopeia)

Expected result AFTER applying this Pull Request
file not saved

Link to documentations
Please select: