Skip to content

fix on change JavaScript event on color form field with layout advanced#41126

Merged
obuisard merged 3 commits intojoomla:4.3-devfrom
jurihahn:staging
Jul 14, 2023
Merged

fix on change JavaScript event on color form field with layout advanced#41126
obuisard merged 3 commits intojoomla:4.3-devfrom
jurihahn:staging

Conversation

@jurihahn
Copy link
Contributor

@jurihahn jurihahn commented Jul 7, 2023

Pull Request

Summary of Changes

"onchange" event don't work on color form field. If I add

<field
	name="my_color"
	type="color"
	control="advanced"
	onchange="alert('color changed');"
/>

I get result HTML result:
<input type="text" name="my_color" ... data-control="advanced" alert('color="" changed');="" data-format="hex" size="7">

Testing Instructions

Create form with color form field and add custom "onchange" for example onchange="alert('color changed');" then load page with this form and select any color

Actual result BEFORE applying this Pull Request

you don't get message "color changed"

Expected result AFTER applying this Pull Request

you get message "color changed"

@Quy
Copy link
Contributor

Quy commented Jul 7, 2023

I have tested this item ✅ successfully on 9193822


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41126.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 9193822


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41126.

@alikon
Copy link
Contributor

alikon commented Jul 8, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41126.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 8, 2023
@obuisard obuisard added this to the Joomla! 4.3.4 milestone Jul 14, 2023
@obuisard obuisard merged commit 5be7121 into joomla:4.3-dev Jul 14, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 14, 2023
@obuisard
Copy link
Contributor

Thank you Juri @jurihahn for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants