fix on change JavaScript event on color form field with layout advanced#41126
Merged
obuisard merged 3 commits intojoomla:4.3-devfrom Jul 14, 2023
Merged
fix on change JavaScript event on color form field with layout advanced#41126obuisard merged 3 commits intojoomla:4.3-devfrom
obuisard merged 3 commits intojoomla:4.3-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 9193822 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41126. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 9193822 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41126. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41126. |
Contributor
|
Thank you Juri @jurihahn for the PR! |
GeraintEdwards
pushed a commit
to GeraintEdwards/joomla-cms
that referenced
this pull request
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary of Changes
"onchange" event don't work on color form field. If I add
I get result HTML result:
<input type="text" name="my_color" ... data-control="advanced" alert('color="" changed');="" data-format="hex" size="7">Testing Instructions
Create form with color form field and add custom "onchange" for example
onchange="alert('color changed');"then load page with this form and select any colorActual result BEFORE applying this Pull Request
you don't get message "color changed"
Expected result AFTER applying this Pull Request
you get message "color changed"