-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[5.x] SQL field plugin #41122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[5.x] SQL field plugin #41122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have tested this item ✅ successfully on fc0dbb2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41122. |
Contributor
Author
|
Would be great to get some testers here as there were a lot of people asking for this field |
Member
|
thanks |
1 similar comment
Contributor
Author
|
thanks |
heelc29
added a commit
to heelc29/joomla
that referenced
this pull request
Aug 13, 2023
GeraintEdwards
pushed a commit
to GeraintEdwards/joomla-cms
that referenced
this pull request
Aug 14, 2023
* [5.x] SQL field plugin * added to the plugin params - n0ot sure why but done for consistency
GeraintEdwards
pushed a commit
to GeraintEdwards/joomla-cms
that referenced
this pull request
Aug 14, 2023
* [5.x] SQL field plugin * added to the plugin params - n0ot sure why but done for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds the ability to have a header in the generated dropdown list as per the documentation https://docs.joomla.org/SQL_form_field_type
Testing Instructions
Create an sql custom field with a simple query eg select a.id as value, a.title as text from uajp8_content as a
Actual result BEFORE applying this Pull Request
Open an article and check the new field - it will be a dropdown list with the first item in the list displayed.
As a result when you save the article that first item will be saved and will therefore be displayed on the front end.
Expected result AFTER applying this Pull Request
There is now an additional param in the field called Header
You can use this to add a header to the dropdown list that has no value eg "- Select something -"
Open an article and check the new field - it will be a dropdown list with the first item in the list being the content you entered in the header field.
As a result when you save the article the field will have no value and will therefore not be displayed on the front end.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed