[5.0] Guided Tours - Record currentStepId in sessionStorage when responding to an interact…#40776
Closed
GeraintEdwards wants to merge 8 commits intojoomla:5.0-devfrom
Closed
[5.0] Guided Tours - Record currentStepId in sessionStorage when responding to an interact…#40776GeraintEdwards wants to merge 8 commits intojoomla:5.0-devfrom
GeraintEdwards wants to merge 8 commits intojoomla:5.0-devfrom
Conversation
…ive button - the button may cause a page redirect or form submission Progree to next step when the button is clicked and not immediately - otherwise then the tour is being set up you can end up with a double modal back drop being created
joomla-cms-bot
added
NPM Resource Changed
GeraintEdwards
changed the title
Member
|
@sdwjoomla since you create some guided tours could you please test this pr |
2 tasks
Contributor
Author
|
Reissued as PR for Joomla 4.3 #41155 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Change handling of 'button' interactive type to respond to the button click rather than immediately executing.
This execution happens at the start of the tour and not when the step has actually been reached and so the modal setup ends up being called twice. As a result other steps with interactive actions e.g. checkboxes or text input fields cannot be interacted with.
Testing Instructions
Create a tour as per following screenshots - a JSON import is attached if you have implemented the tours import/export PR #40645
backdropProblemTour.zip
Unpublish steps 3 and 4 so that you have this as an overview
Now run the tour
Actual result BEFORE applying this Pull Request
At step 2 you have a double backdrop and can't interact with the checkbox
If you enable steps 3 and 4 it behaves even worse
and if you proceed with clicking the rebuild button you get stuck in a loop.
Expected result AFTER applying this Pull Request
You also don't get a loop on the rebuild button action step
Link to documentations
Please select:
Documentation link for docs.joomla.org:
[x ] No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
[ x] No documentation changes for manual.joomla.org needed