Skip to content

Conversation

@brianteeman
Copy link
Contributor

Pull Request for Issue #40517 .

Summary of Changes

@laoneo](https://github.com/laoneo) removed this use statement with #39624. I assuming it was in error

Testing Instructions

see #40517

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@dgrammatiko
Copy link
Contributor

Actually the correct solution is to change line 87 from
$_errorMessage = Text::_('JLIB_LOGIN_DENIED');
to
$_errorMessage = $this->getApplication()->getLanguage()->_('JLIB_LOGIN_DENIED');

@sandewt
Copy link
Contributor

sandewt commented May 1, 2023

$_errorMessage = Text::_('JLIB_LOGIN_DENIED');

I think this was the intention:

$response->error_message = $this->getApplication()->getLanguage()->_('JLIB_LOGIN_DENIED');

This can then expire again:
use Joomla\CMS\Language\Text;

[EDIT I just missed the previous post]

@laoneo
Copy link
Member

laoneo commented May 1, 2023

Tanks @brianteeman for the fast pr. Can you change the pr to the proposal from @dgrammatiko?

@richard67
Copy link
Member

I have tested this item ✅ successfully on 7f1fe05

To reproduce the error I had to switch the site to offline in addition to what's described in issue #40517 .

See also #40517 (comment) .


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40518.

@richard67 richard67 added the bug label May 1, 2023
@laoneo
Copy link
Member

laoneo commented May 1, 2023

I have tested this item ✅ successfully on 7f1fe05


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40518.

@richard67 richard67 removed the bug label May 1, 2023
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40518.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 1, 2023
@richard67 richard67 added the bug label May 1, 2023
@sdwjoomla sdwjoomla merged commit f9e700c into joomla:4.3-dev May 6, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 6, 2023
@sdwjoomla
Copy link
Contributor

Thanks brianteeman

@sdwjoomla sdwjoomla added this to the Joomla! 4.3.2 milestone May 6, 2023
@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the patch-5 branch May 6, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants