Closed
Conversation
Member
|
I don't think this PR is sufficient. In the issue, the not matching schema version was just an example for causing a database error. But the check in the update component includes a complete schema check like it is executed when you go to the database checker in backend. The not matching schema version in the issue was just an easy example how to cause a schema error. But it is not the only possible error. E.g. when you add a new update SQL script to your installation which creates a new table, it would result in a schema error shown by the database checker, and this would block the update in the pre-update checker, too. |
Contributor
Author
|
see #40468 should do all the schema checks |
Member
|
@alikon See my comment in your new PR. |
Contributor
Author
|
closing in favour of #40468 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Partial Pull Request for Issue #40444 only the db schema part
Summary of Changes
added the schema check
Testing Instructions
see #40444
Actual result BEFORE applying this Pull Request
N/A
Expected result AFTER applying this Pull Request
Schema is checked and Update is not able to proceed if there is a database structure issue
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed