Skip to content

Comments

[4][cli] schema update check#40461

Closed
alikon wants to merge 2 commits intojoomla:4.3-devfrom
alikon:patch-4
Closed

[4][cli] schema update check#40461
alikon wants to merge 2 commits intojoomla:4.3-devfrom
alikon:patch-4

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Apr 23, 2023

Partial Pull Request for Issue #40444 only the db schema part

Summary of Changes

added the schema check

Testing Instructions

see #40444

Actual result BEFORE applying this Pull Request

N/A

Expected result AFTER applying this Pull Request

Schema is checked and Update is not able to proceed if there is a database structure issue

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

I don't think this PR is sufficient. In the issue, the not matching schema version was just an example for causing a database error. But the check in the update component includes a complete schema check like it is executed when you go to the database checker in backend. The not matching schema version in the issue was just an easy example how to cause a schema error. But it is not the only possible error. E.g. when you add a new update SQL script to your installation which creates a new table, it would result in a schema error shown by the database checker, and this would block the update in the pre-update checker, too.

@alikon alikon mentioned this pull request Apr 24, 2023
4 tasks
@alikon
Copy link
Contributor Author

alikon commented Apr 24, 2023

see #40468

should do all the schema checks
something like

image

@richard67
Copy link
Member

@alikon See my comment in your new PR.

@alikon
Copy link
Contributor Author

alikon commented Apr 24, 2023

closing in favour of #40468

@alikon alikon closed this Apr 24, 2023
@alikon alikon deleted the patch-4 branch April 24, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants