[5.0] Plugins: load language only when plugin it really needed. Performance optimisation.#40356
Merged
HLeithner merged 11 commits intojoomla:5.0-devfrom Sep 17, 2023
Merged
Conversation
Conflicts: plugins/system/jooa11y/src/Extension/Jooa11y.php plugins/system/redirect/src/Extension/Redirect.php plugins/system/tasknotification/src/Extension/TaskNotification.php
Conflicts: plugins/system/actionlogs/src/Extension/ActionLogs.php
Contributor
|
I installed German, logged in to Admin with German selected, applied patch and got this: Die zu ändernde Datei existiert nicht: plugins/system/logrotation/src/Extension/LogRotation.php Same with English, with Patchtester the patch won't apply - error message: The file marked for modification does not exist: plugins/system/logrotation/src/Extension/LogRotation.php This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40356. |
Contributor
Member
|
I merge this since it seems a useful optimization and could be better tested in beta2 and easily fixed or reverted if a translation is missing. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

in addittion to #40355 and #40309
Summary of Changes
Most of the plugins wasting a time for loading their language, while it may never used.
I have reviewed some system plugins, and changed
$autoloadLanguageto manual loading, on specific event.It still need some work, but need to wait when #40216 will be merged and upmerged :)Testing Instructions
Apply patch, make sure the plugins translations still works.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select: