Skip to content

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented Apr 1, 2023

Pull Request for Issue #40285 .

Summary of Changes

This pull request (PR) updates the version numbers in files "plugins/editors/codemirror/codemirror.xml" and "plugins/editors/tinymce/tinymce.xml", which has obviously been forgotten with a pervious update of these dependencies.

Testing Instructions

Code review: Check that the version number in the changed xml files fit to what is in file "package-lock.json".

For codemirror see https://github.com/joomla/joomla-cms/blob/5.0-dev/package-lock.json#L11934 .

For tinymce see https://github.com/joomla/joomla-cms/blob/5.0-dev/package-lock.json#L16196 .

Actual result BEFORE applying this Pull Request

Codemirror has 5.65.9 and tinymce has 6.2.0 in the XML file.

Expected result AFTER applying this Pull Request

Codemirror has 5.65.12 and tinymce has 6.4.0 in the XML file.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

@richard67 richard67 changed the title Update versions in codemirror.xml and tinymce.xml [5.0] Update versions in codemirror.xml and tinymce.xml Apr 1, 2023
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 7db46ad

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40287.

@Quy
Copy link
Contributor

Quy commented Apr 1, 2023

I have tested this item ✅ successfully on 7db46ad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40287.

@Quy
Copy link
Contributor

Quy commented Apr 1, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40287.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 1, 2023
@HLeithner HLeithner merged commit dde5763 into joomla:5.0-dev Apr 2, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 2, 2023
@HLeithner
Copy link
Member

Thanks, but this should really be part of the bump script at some point

@brianteeman
Copy link
Contributor

@HLeithner it is already part of the npm scripts that are responsible for handling changes created as a result of several dependencies.

@HLeithner
Copy link
Member

@brianteeman sound great, do you know why it didn't worked?

@brianteeman
Copy link
Contributor

it did work - the files were changed they were just not committed

@HLeithner
Copy link
Member

ah ok thanks ;-)

@brianteeman
Copy link
Contributor

thats why it is best to only change one thing in a PR. It is easy to see then that there were some changed files to commit from the npm update. You probably didnt see them when you made the pull request as there were so many other things in that PR. It's also why no one spotted it at the time of the pr

@richard67 richard67 deleted the 5.0-dev-update-codemirror-and-tinymce-xml-files branch April 2, 2023 09:10
@richard67 richard67 added this to the Joomla! 5.0 milestone Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants