[4.3] Fix SQL error "Can't Drop 'asset_id'; check that column/key exists" and checked out Guided Tours module when updating from 4.2.9 or older#40286
Merged
obuisard merged 2 commits intojoomla:4.3-devfrom Apr 2, 2023
Conversation
Contributor
|
I have tested this item ✅ successfully on ce538b6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40286. |
Contributor
|
I have tested this item ✅ successfully on ce538b6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40286. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40286. |
Contributor
|
I have tested this item ✅ successfully on ce538b6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40286. |
Contributor
|
Thank you Richard @richard67 for the PR and all for testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request for Issue #40284 .
Summary of Changes
This pull request (PR) adds the "CAN FAIL" installer hint to the drop column statement in the "4.3.0-2023-03-28.sql" update script.
The reason is that with PR #40228 the update SQL script "4.3.0-2023-02-15.sql" has been changed, too, so the column does not exist when not updating from a 4.3.0 beta 4 or rc 1 but an older version.
In addition, this PR fixes the value of the checked out column of the Guided Tours module installed with the "4.3.0-2023-02-15.sql" script on update.
Testing Instructions
Update from a 4.2.9 or a current 4.2-dev branch to the last 4.3-dev nightly build to reproduce the issue, and to the update package or custom update URL built by drone for this PR to test the fix.
Actual result BEFORE applying this Pull Request
SQL error about column not existing.
Com_checkin shows something checked out in the modules table. Checking in database shows that it is the Guided Tours module.
Expected result AFTER applying this Pull Request
No SQL error.
Nothing is checked out in com_checkin after the update.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed