[4.3] Guided Tours fix js error#40282
Merged
obuisard merged 2 commits intojoomla:4.3-devfrom Apr 2, 2023
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 9d852f1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40282. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 9d852f1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40282. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40282. |
Contributor
|
Thank you @heelc29 for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
fix call of
Joomla.renderMessagesTesting Instructions
set an invalid
data-idfor exampledata-id="0"joomla-cms/administrator/modules/mod_guidedtours/tmpl/default.php
Line 73 in 338a940
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
error message is rendered without js error

Link to documentations
Please select: