Skip to content

[4.3] Fixing comparison in Url Filter #40229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2023
Merged

[4.3] Fixing comparison in Url Filter #40229

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae1cb23
Fixing comparison in Url Filter
Hackwar Mar 29, 2023
d972072
Lets make the code easier...
Hackwar Mar 29, 2023
10fdf5e
Merge branch '4.3-dev' into 4.3-urlfilter
obuisard Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/src/Form/Filter/UrlFilter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function filter(\SimpleXMLElement $element, $value, $group = null, Regist
// we assume that it is an external URL and prepend http://
if (
((string) $element['type'] === 'url' && !$protocol && !$element['relative'])
|| (!(string) $element['type'] === 'url' && !$protocol)
|| ((string) $element['type'] !== 'url' && !$protocol)
) {
$protocol = 'http';

Expand Down