Skip to content

[4.3] Add Create and Edit Own permissions for tours#40220

Closed
joomdonation wants to merge 2 commits intojoomla:4.3-devfrom
joomdonation:add_missing_tour_permissions
Closed

[4.3] Add Create and Edit Own permissions for tours#40220
joomdonation wants to merge 2 commits intojoomla:4.3-devfrom
joomdonation:add_missing_tour_permissions

Conversation

@joomdonation
Copy link
Contributor

@joomdonation joomdonation commented Mar 27, 2023

Pull Request for Issue #40200.

Summary of Changes

This PR does several things :

  1. Add missing Create and Edit Own permissions for tours.
  2. Handle these new permissions properly for tours.
  3. Make sure steps inherit permissions properly from tour it belong to

Testing Instructions

  1. Use Joomla 4.3 nightly build
  2. Apply PR [Guided Tours] All tour assets get the root id #40208 first (this PR depends on that PR)
  3. Apply patch, make sure Create and Edit Own permissions are working properly for tours.
  4. Make sure steps inherit Create and Edit Own permissions properly from tour it belong to.

Actual result BEFORE applying this Pull Request

  • The permissions are missing for tours
  • Steps are not inherited permissions properly from the tour it belong to

Expected result AFTER applying this Pull Request

  • The missing permissions are added.
  • Steps inherit permissions properly from the tour it belong to.

Link to documentations

Please select:

@richard67
Copy link
Member

See an alternative PR here, which removes the permissions for tours: #40228 .

@joomdonation
Copy link
Contributor Author

Closing because we decided to remove permissions from tours

@joomdonation joomdonation deleted the add_missing_tour_permissions branch February 24, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants