Skip to content

Conversation

@chmst
Copy link
Contributor

@chmst chmst commented Mar 26, 2023

Pull Request for Issue # .

Summary of Changes

Fix deprecated warning in contenthistory. It is caused by the null value for example in checked_out_time.

grafik

Testing Instructions

See screenshot. Oben the contenthistory of an article and open one if the versions.

Actual result BEFORE applying this Pull Request

See screenshot

Expected result AFTER applying this Pull Request

No warning

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@chmst chmst added PHP 8.x PHP 8.x deprecated issues Small A PR which only has a small change labels Mar 26, 2023
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on f66757c

issue replicated and confirmed resolved with this pr


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40213.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on f66757c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40213.

@joomla-cms-bot joomla-cms-bot removed PHP 8.x PHP 8.x deprecated issues PR-4.3-dev Small A PR which only has a small change labels Mar 27, 2023
@alikon
Copy link
Contributor

alikon commented Mar 27, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40213.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 27, 2023
@richard67 richard67 added PHP 8.x PHP 8.x deprecated issues PR-4.3-dev Small A PR which only has a small change labels Mar 27, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Mar 29, 2023
@obuisard obuisard merged commit dd2e875 into joomla:4.3-dev Mar 29, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 29, 2023
@obuisard
Copy link
Contributor

Thank you Christiane @chmst for the PR!

@chmst chmst deleted the contenthistoryhelper-deprecated branch December 13, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PHP 8.x PHP 8.x deprecated issues Small A PR which only has a small change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants