Skip to content

Fix incorrect HTML rendering #40194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2023
Merged

Fix incorrect HTML rendering #40194

merged 1 commit into from
Mar 25, 2023

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Mar 25, 2023

Pull Request for Issue #40185 .

Summary of Changes

Fixing incorect HTML rendering

Testing Instructions

Please follow #40185

Actual result BEFORE applying this Pull Request

You get double <body> tag

Expected result AFTER applying this Pull Request

There only 1 <body> tag

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@Fedik Fedik mentioned this pull request Mar 25, 2023
Closed
@Quy
Copy link
Contributor

Quy commented Mar 25, 2023 •
edited
Loading

I have tested this item ✅ successfully on 0182146

Before:

<div class="header-dd-item dropdown-item" data-item="1"><!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<?xml encoding="utf-8" ?><html><body><div class="header-item-content dropdown header-tours d-none d-sm-block">
    <button class="dropdown-toggle d-flex align-items-center ps-0 py-0" data-bs-toggle="dropdown" type="button" title="Take a Tour">
        <div class="header-item-icon">
            <span class="icon-map-signs" aria-hidden="true"></span>
        </div>
        <div class="header-item-text">
            Take a Tour        </div>
        <span class="icon-angle-down" aria-hidden="true"></span>
    </button>
    <div class="dropdown-menu dropdown-menu-end">
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="3">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create articles?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="4">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create categories?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="5">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create menus?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="6">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create tags?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="7">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create banners?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="8">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create contacts?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="9">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to enter a news feed?            </button>
                                            <button type="button" class="dropdown-item text-center" data-bs-toggle="modal" data-bs-target="#modGuidedTours-modal">
            Show all tours        </button>
    </div>
</div>
</body></html>
</div>

After:

<div class="header-dd-item dropdown-item" data-item="1"><div class="header-item-content dropdown header-tours d-none d-sm-block">
    <button class="dropdown-toggle d-flex align-items-center ps-0 py-0" data-bs-toggle="dropdown" type="button" title="Take a Tour">
        <div class="header-item-icon">
            <span class="icon-map-signs" aria-hidden="true"></span>
        </div>
        <div class="header-item-text">
            Take a Tour        </div>
        <span class="icon-angle-down" aria-hidden="true"></span>
    </button>
    <div class="dropdown-menu dropdown-menu-end">
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="3">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create articles?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="4">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create categories?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="5">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create menus?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="6">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create tags?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="7">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create banners?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="8">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create contacts?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="9">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to enter a news feed?            </button>
                                            <button type="button" class="dropdown-item text-center" data-bs-toggle="modal" data-bs-target="#modGuidedTours-modal">
            Show all tours        </button>
    </div>
</div>
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40194.

@joomdonation
Copy link
Contributor

joomdonation commented Mar 25, 2023

I have tested this item ✅ successfully on 0182146

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40194.

@joomdonation
Copy link
Contributor

joomdonation commented Mar 25, 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40194.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 25, 2023
@Quy Quy added the PR-4.3-dev label Mar 25, 2023
@heelc29
Copy link
Contributor

heelc29 commented Mar 25, 2023

I have tested this item ✅ successfully on 0182146

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40194.

@obuisard
Copy link
Contributor

obuisard commented Mar 25, 2023

Thank you guys for looking into it, it does fix the problem.

@obuisard obuisard added this to the Joomla! 4.3.0 milestone Mar 25, 2023
@obuisard obuisard merged commit 7644c36 into joomla:4.3-dev Mar 25, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 25, 2023
@obuisard
Copy link
Contributor

obuisard commented Mar 25, 2023

Thank you, Fedir @Fedik for the fix!

@Fedik Fedik deleted the fix40185 branch March 25, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla! 4.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Fedik @Quy @joomdonation @heelc29 @obuisard @joomla-cms-bot