Prevent Exception #40122
Merged
Prevent Exception #40122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laoneo
reviewed
Mar 15, 2023
Contributor
|
I have tested this item ✅ successfully on 85341dd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40122. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 85341dd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40122. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40122. |
Member
|
This pull request has been automatically rebased to 4.3-dev. |
Contributor
|
Hello @janschoenherr, can you check the conflict? Thank you! |
janschoenherr
requested review from
HLeithner,
bembelimen,
rdeutz and
wilsonge
as code owners
joomla-cms-bot
added
NPM Resource Changed
joomla-cms-bot
removed
the
NPM Resource Changed
If $parts is `null` this will throw an exception. ```count(): Argument joomla#1 ($value) must be of type Countable|array, null given``` This can happen if the context is e.g. the default context `text` from the `Joomla\CMS\HTML\Helpers\Content::prepare()` function.
Contributor
Author
|
Conflicts are resolved. Thanks. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If $parts is
nullthis will throw an exception in PHP 8+, a warning in PHP 7.count(): Argument #1 ($value) must be of type Countable|array, null givenThis can happen if the context is e.g. the default context
textfrom theJoomla\CMS\HTML\Helpers\Content::prepare()function.Pull Request for Issue #40121.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed