Skip to content

Conversation

@svenbluege
Copy link
Contributor

Deprecation messages are shown for some tagged elements:
image

Summary of Changes

In com_tags, a tagged element's text-variable is transformed into null if the value is empty.
That causes deprecation messages in plugins like loadmodules and emailcloak. They usually don't need to check for null values in $article->text.

Testing Instructions

  1. configure PHP to show deprecation messages
  2. create a new contact using com_contact: just enter a name and tag it with "testtag"
  3. open the frontend /index.php?option=com_tags&view=tags
  4. click on the new tag 'testtag'.
  5. see the deprecation messages.

Actual result BEFORE applying this Pull Request

Following the test instructions, deprecation messages are shown

Expected result AFTER applying this Pull Request

Following the test instructions, deprecation messages are now shown

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

…l if the value is empty.

That causes deprecation messages in plugins like loadmodules and emailcloak. They usually don't need to check for null values in $article->text.
@svenbluege
Copy link
Contributor Author

This issue was fixed with the same code in 4.2.7, I'm missing the change in 4.3. Here is my try to add it to 4.3 again.
Original PR which was included in 4.2.7: #39640

@Quy
Copy link
Contributor

Quy commented Mar 9, 2023

I have tested this item ✅ successfully on 548adf2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40048.

@Quy
Copy link
Contributor

Quy commented Mar 9, 2023

@obuisard This was missed in the upmerge. Should be ok to merge without an additional test.

@obuisard obuisard added this to the Joomla! 4.3.0 milestone Mar 10, 2023
@obuisard obuisard merged commit bdbc503 into joomla:4.3-dev Mar 10, 2023
@obuisard
Copy link
Contributor

Thank you Sven @svenbluege for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants