[4.3][Guided Tours] Cleanup Tours model

[joomdonation]

Pull Request for Issue # .

Summary of Changes

This PR makes several clean up to Tours module from Guided Tours extension

• No need to override getEmptyStateQuery method from parent class (This override contains really wrong code, seems copied from Steps model)
• Remove getTable method. We do not need this method from a List model

Testing Instructions

• Install Joomla from download package generated by this PR (to make sure Guided Tours is available on your installation). Access to Guided Tours, see list of tours and make sure nothing is broken from this page

Actual result BEFORE applying this Pull Request

Unnecessary wrong code in Tours model

Expected result AFTER applying this Pull Request

The unnecessary wrong code removed.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[joomdonation]

Question for @obuisard : In this model, we also have code to handle extensions filter (no idea how it should work). However, that filter is not in filter form, so should we remove that code as well ?

[obuisard]

Question for @obuisard : In this model, we also have code to handle extensions filter (no idea how it should work). However, that filter is not in filter form, so should we remove that code as well ?

No, it is used by the Guided Tours module to show tours according to a specific extension that is showing on the screen.

[joomdonation]

No, it is used by the Guided Tours module to show tours according to a specific extension that is showing on the screen

Ah, OK. Thanks for the info.

[obuisard]

I have tested this item ✅ successfully on 17b1444

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40003.}

[Quy]

I have tested this item ✅ successfully on 17b1444

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40003.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40003.}

[obuisard]

Thank you Tuan @joomdonation!