Skip to content

[4.3][Guided Tours] Fixed News Feed tour and User tour target#40000

Merged
obuisard merged 15 commits intojoomla:4.3-devfrom
khu5h1:fix
Mar 12, 2023
Merged

[4.3][Guided Tours] Fixed News Feed tour and User tour target#40000
obuisard merged 15 commits intojoomla:4.3-devfrom
khu5h1:fix

Conversation

@khu5h1
Copy link
Contributor

@khu5h1 khu5h1 commented Mar 4, 2023

Pull Request for Issue #40001
Guided Tour Project #39902

Summary of Changes

Fixed News Feed Status target

Actual result BEFORE applying this Pull Request

main

Expected result AFTER applying this Pull Request

2

@khu5h1 khu5h1 changed the title [4.3] Fixed News Feed Status target [4.3] [Guided Tours] Fixed News Feed Status target Mar 8, 2023
@Quy
Copy link
Contributor

Quy commented Mar 8, 2023

Please fix update sql files. See samples: 5e4c0dd

@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Mar 8, 2023
@khu5h1 khu5h1 changed the title [4.3] [Guided Tours] Fixed News Feed Status target [4.3][Guided Tours] Fixed News Feed tour and User tour target Mar 9, 2023
@obuisard
Copy link
Contributor

obuisard commented Mar 9, 2023

Khushi @khu5h1 the latest SQL updates are incorrect. They will replace more than what needs to be replaced. You need to be more specific in the WHERE clause :-)

UPDATE `#__guidedtour_steps`
SET `target` = '#jform_published'
WHERE `target` = '#jform_state';

@khu5h1
Copy link
Contributor Author

khu5h1 commented Mar 9, 2023

@obuisard Sure, Updating the WHERE clause. Thanks!

@Quy Quy removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Mar 9, 2023
obuisard added 2 commits March 9, 2023 15:07
Uppercased AND changed quotes on id
@obuisard
Copy link
Contributor

obuisard commented Mar 9, 2023

I have tested this item ✅ successfully on 0dd1365


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40000.

@khu5h1
Copy link
Contributor Author

khu5h1 commented Mar 10, 2023

Hi @Quy, It would be great if you could test this PR whenever you get time so, that we can merge it before the RC. Thanks!

@ChristineWk
Copy link

@obuisard
Unfortunately I hv updated to 4.3.0-beta5-dev (before). Therefore response:
The patch could not be applied because it conflicts with a previously applied patch: administrator/components/com_admin/sql/updates/mysql/4.3.0-2023-02-15.sql


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40000.

@obuisard
Copy link
Contributor

@obuisard Unfortunately I hv updated to 4.3.0-beta5-dev (before). Therefore response: The patch could not be applied because it conflicts with a previously applied patch: administrator/components/com_admin/sql/updates/mysql/4.3.0-2023-02-15.sql

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40000.

Hi @ChristineWk. Some times you cannot try patches simultaneously. Once you try a patch you should revert it so that the next patch does not rely on the previous one or create conflict.

@ChristineWk
Copy link

Hi @obuisard I tried the patch a few days before. It was unsuccessful. Checked also sql and was not sure about ....
Due to subsequent changes sql - I tried again today, but with an updated 4.3.0-beta5-dev
Had of course reverted before that.

@sdwjoomla
Copy link
Contributor

I have tested this item ✅ successfully on d8a35b2

Step 7 highlighted the Status field


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40000.

@Quy
Copy link
Contributor

Quy commented Mar 11, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40000.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 11, 2023
@Quy Quy added this to the Joomla! 4.3.0 milestone Mar 11, 2023
@obuisard obuisard merged commit e06d828 into joomla:4.3-dev Mar 12, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 12, 2023
@obuisard
Copy link
Contributor

Thank you Khushi @khu5h1 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants