[4.3] PHP8.2: Updating voku/portable-utf8 #39955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I have tested this item ✅ successfully on 44f9ff1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39955. |
Member
|
I have tested this item ✅ successfully on 44f9ff1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39955. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39955. |
Contributor
|
Thank you Hannes @Hackwar ! |
Member
|
We have the same problem in 4.2.9 |
Member
Author
|
This class is not used during installation of Joomla. |
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 12, 2023
2 tasks
obuisard
pushed a commit
that referenced
this pull request
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #39512.
Summary of Changes
Our wamania/php-stemmer requires voku/portable-utf8, which in the 5.4 version is not compatible with PHP 8.2. Version 6.0 actually is and since the code for the stemmer is compatible, we can thus update voku/portable-utf8 now with this. php-stemmer will most likely not update it for the 2.x version we are using. For Joomla 5 this is probably going to be done through our dependency updates.
Testing Instructions
Apply the change (together with composer install) and then run the indexer of smart search and afterwards search something in the frontend. Make sure that the stemmer is selected in the global options of Smart Search by setting "Default Language" to "Default Site Language". All of this in PHP 8.2
Actual result BEFORE applying this Pull Request
You see a notice.
Expected result AFTER applying this Pull Request
You don't see a notice.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed