[4.2] Revert 39329 - Release Blocker#39943
Merged
wilsonge merged 3 commits intojoomla:4.2-devfrom Feb 27, 2023
Merged
Conversation
4 tasks
Contributor
|
I have tested this item ✅ successfully on ab123fd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39943. |
Contributor
|
Shouldn't this PR target 4.2-dev branch? Otherwise, we would get this bug for next release 4.2.9. |
Contributor
Author
|
yes it should. I mistakenly assumed it had been merged in this branch.. Rebasing |
ab123fd to
4b4f595
Compare
Contributor
|
I have tested this item ✅ successfully on 4b4f595 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39943. |
Contributor
|
@toivo When you have a moment, please test it again with 4.2-dev. Thanks ! |
Contributor
|
I have tested this item ✅ successfully on 4b4f595 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39943. |
Contributor
|
RTC. Thanks. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39943. |
Contributor
|
Thanks! |
Contributor
Author
|
Thanks @wilsonge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #39934