Skip to content

[4.2] Revert 39329 - Release Blocker#39943

Merged
wilsonge merged 3 commits intojoomla:4.2-devfrom
brianteeman:tempolate_check
Feb 27, 2023
Merged

[4.2] Revert 39329 - Release Blocker#39943
wilsonge merged 3 commits intojoomla:4.2-devfrom
brianteeman:tempolate_check

Conversation

@brianteeman
Copy link
Contributor

see #39934

@toivo
Copy link
Contributor

toivo commented Feb 26, 2023

I have tested this item ✅ successfully on ab123fd

Tested successfully in Joomla 4.3.0-beta4-dev of 26 February.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39943.

@joomdonation
Copy link
Contributor

Shouldn't this PR target 4.2-dev branch? Otherwise, we would get this bug for next release 4.2.9.

@brianteeman
Copy link
Contributor Author

yes it should. I mistakenly assumed it had been merged in this branch.. Rebasing

@brianteeman brianteeman changed the base branch from 4.3-dev to 4.2-dev February 26, 2023 07:46
@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on 4b4f595

Solved the issue as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39943.

@richard67 richard67 changed the title [4.3] Revert 39329 - Release Blocker [4.2] Revert 39329 - Release Blocker Feb 26, 2023
@joomdonation
Copy link
Contributor

@toivo When you have a moment, please test it again with 4.2-dev. Thanks !

@toivo
Copy link
Contributor

toivo commented Feb 26, 2023

I have tested this item ✅ successfully on 4b4f595

Tested successfully in Joomla 4.2.9-dev of 26 February using PHP 8.1.10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39943.

@joomdonation
Copy link
Contributor

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39943.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 26, 2023
@joomdonation joomdonation added this to the Joomla! 4.2.9 milestone Feb 26, 2023
@Hackwar Hackwar added the Small A PR which only has a small change label Feb 26, 2023
@wilsonge wilsonge merged commit 6798f07 into joomla:4.2-dev Feb 27, 2023
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 27, 2023
@brianteeman brianteeman deleted the tempolate_check branch February 27, 2023 15:38
@brianteeman
Copy link
Contributor Author

Thanks @wilsonge

@ReLater ReLater mentioned this pull request May 27, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Small A PR which only has a small change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

Comments