Skip to content

[5.3] Shortening the code for 'No Media found' in Media Manager#39835

Merged
rdeutz merged 7 commits intojoomla:5.3-devfrom
rajputanuj31:isEmpty
Aug 25, 2025
Merged

[5.3] Shortening the code for 'No Media found' in Media Manager#39835
rdeutz merged 7 commits intojoomla:5.3-devfrom
rajputanuj31:isEmpty

Conversation

@rajputanuj31
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

Shortening the code

Testing Instructions

Choose a empty folder in media.

Same Behavior before and after the PR.
Just code refactoring.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev labels Feb 11, 2023
@Hackwar Hackwar added the Small A PR which only has a small change label Feb 25, 2023
@Hackwar Hackwar added the bug label Apr 7, 2023
@HLeithner HLeithner changed the base branch from 4.3-dev to 4.4-dev September 30, 2023 22:44
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 4.4-dev.

@Hackwar Hackwar added the PBF Pizza, Bugs and Fun label Feb 21, 2024
@HLeithner HLeithner changed the title [4.3] Shortening the code for 'No Media found' in Media Manager [4.4] Shortening the code for 'No Media found' in Media Manager Apr 24, 2024
@HLeithner HLeithner changed the base branch from 4.4-dev to 5.2-dev November 15, 2024 13:21
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.2-dev.

@HLeithner HLeithner changed the title [4.4] Shortening the code for 'No Media found' in Media Manager [5.2] Shortening the code for 'No Media found' in Media Manager Nov 15, 2024
@richard67 richard67 removed PBF Pizza, Bugs and Fun PR-4.4-dev labels Jan 19, 2025
@webmasterab
Copy link
Contributor

I have tested this item ✅ successfully on a550bad

I tested this.

Created a new folder for the patch and was shown an empty folder.

After the path it was exactly the same what I saw.

So the code cleanup seems fine


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39835.

@HLeithner HLeithner changed the base branch from 5.2-dev to 5.3-dev April 15, 2025 16:16
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.3-dev.

@HLeithner HLeithner changed the title [5.2] Shortening the code for 'No Media found' in Media Manager [5.3] Shortening the code for 'No Media found' in Media Manager Apr 15, 2025
@MacJoom
Copy link
Contributor

MacJoom commented Aug 23, 2025

I have tested this item ✅ successfully on a550bad

Patch installed (local installation) - npm ci - checked that mediamanager was rebuild - No changes in behavior


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39835.

@richard67 richard67 added PBF Pizza, Bugs and Fun and removed PR-5.3-dev labels Aug 23, 2025
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39835.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 23, 2025
@rdeutz rdeutz enabled auto-merge (squash) August 25, 2025 15:36
@rdeutz
Copy link
Contributor

rdeutz commented Aug 25, 2025

Thanks

@rdeutz rdeutz added this to the Joomla! 5.3.4 milestone Aug 25, 2025
@rdeutz rdeutz merged commit 2f5a04c into joomla:5.3-dev Aug 25, 2025
39 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug NPM Resource Changed This Pull Request can't be tested by Patchtester PBF Pizza, Bugs and Fun Small A PR which only has a small change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants