Skip to content

[5.0] CMSApplication: Switching to triggerEvent #39752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hackwar wants to merge 5 commits into from
Closed

[5.0] CMSApplication: Switching to triggerEvent #39752

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6eaa961
CMSApplication: Switching to triggerEvent
Hackwar Jan 30, 2023
b0e9358
Merge branch '4.3-dev' into 4.2-application-event
Hackwar Mar 5, 2023
053809a
Changing to dispatchEvent()
Hackwar Mar 23, 2023
32c7a83
Merge branch '4.4-dev' into 4.2-application-event
Hackwar Apr 3, 2023
cd86fde
Merge branch '5.0-dev' into 4.2-application-event
laoneo Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions libraries/src/Application/CMSApplication.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ public function execute()
$this->compress();

// Trigger the onAfterCompress event.
$this->triggerEvent('onAfterCompress');
$this->dispatchEvent('onAfterCompress');
}
} catch (\Throwable $throwable) {
/** @var ErrorEvent $event */
Expand All @@ -317,19 +317,19 @@ public function execute()
);

// Trigger the onError event.
$this->triggerEvent('onError', $event);
$this->dispatchEvent('onError', $event);

ExceptionHandler::handleException($event->getError());
}

// Trigger the onBeforeRespond event.
$this->getDispatcher()->dispatch('onBeforeRespond');
$this->dispatchEvent('onBeforeRespond');

// Send the application response.
$this->respond();

// Trigger the onAfterRespond event.
$this->getDispatcher()->dispatch('onAfterRespond');
$this->dispatchEvent('onAfterRespond');
}

/**
Expand Down