-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Introduce an Ldap factory in the authentication plugin #39661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce an Ldap factory in the authentication plugin #39661
Conversation
|
Was not aware of #38775. This one should be merged first, and then I will adapt mine as well. |
Co-authored-by: Quy <[email protected]>
|
The changes already handle some of my TODOs after my PRs are accepted, so thanks for that :) But when I try a login, I get: |
|
Somehow the changes got reverted in the provider file. Fixed that. |
|
It's working now |
|
Thank you Allon @laoneo! |
Summary of Changes
Introduces an Ldap factory in the authentication plugin for better testing capability. The existing test is moved to the integration test suite as it is not a unit test. A new unit test class is added as well and some smaller code cleanup like camel case variables.
This should only be considered after #39624 got merged.
Testing Instructions
Is covered by unit and integration test.
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed