Skip to content

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Jan 11, 2023

Summary of Changes

Updates the debug bar dependency which contains severeal PHP 8.x compatibility fixes.

Testing Instructions

  • Enable debugging in the joomla configuration
  • Open Joomla on PHP 8.2

Actual result BEFORE applying this Pull Request

The following error is shown:
Creation of dynamic property DebugBar\DataFormatter\DataFormatter::$cloner is deprecated in

Expected result AFTER applying this Pull Request

No debug bar related deprecate warning is shown.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

Doesnt this have to be in 4.3 ?

(and its not an error or warning its a notice. isnt it?)

@laoneo
Copy link
Member Author

laoneo commented Jan 11, 2023

My intention was to improve compatibility for PHP 8.2 in 4.2. So we do not have to wait for 4.3. I'l leave it for the RL to decide.

@carlitorweb
Copy link
Member

I have tested this item ✅ successfully on faeac11

Remember for those who test, do composer install


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39594.

@alikon
Copy link
Contributor

alikon commented Jan 14, 2023

I have tested this item ✅ successfully on faeac11


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39594.

@Quy Quy added PHP 8 and removed Composer Dependency Changed PHP 8.x PHP 8.x deprecated issues labels Jan 14, 2023
@Quy
Copy link
Contributor

Quy commented Jan 14, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39594.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 14, 2023
@Quy Quy added NPM Resource Changed This Pull Request can't be tested by Patchtester PHP 8.x PHP 8.x deprecated issues and removed PHP 8 labels Jan 14, 2023
@joomla-cms-bot joomla-cms-bot added Composer Dependency Changed and removed NPM Resource Changed This Pull Request can't be tested by Patchtester labels Jan 14, 2023
@roland-d roland-d merged commit f8995d6 into joomla:4.2-dev Jan 14, 2023
@roland-d roland-d deleted the php82/debugbar branch January 14, 2023 13:45
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 14, 2023
@roland-d
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants