[4.2] Fix permission overridecheck quickicon

[heelc29]

Summary of Changes

The permission for show the quickicon and the link/ajax do not match (com_installer vs. com_templates)

joomla-cms/plugins/quickicon/overridecheck/overridecheck.php

Lines 68 to 77 in e9b9263

	if ($context !== $this->params->get('context', 'update_quickicon') || !$this->app->getIdentity()->authorise('core.manage', 'com_installer')) {
	return array();
	}
	$token = Session::getFormToken() . '=1';
	$options = array(
	'url' => Uri::base() . 'index.php?option=com_templates&view=templates',
	'ajaxUrl' => Uri::base() . 'index.php?option=com_templates&view=templates&task=template.ajax&' . $token,
	'pluginId' => $this->getOverridePluginId(),
	);

Testing Instructions

Check the admin dashboard with a user with these permissions:

Actual result BEFORE applying this Pull Request

Ajax request get 403 status (forbidden)

When you click on the quickicon

Expected result AFTER applying this Pull Request

The quickicon is no longer displayed

Now if you swap permissions for com_installer/com_templates, the quickicon works correctly:

Link to documentations

Please select:

• No documentation changes for docs.joomla.org needed
• No documentation changes for manual.joomla.org needed

[carlitorweb]

I have tested this item ✅ successfully on 9427139

Note: For get the right permission the test require, is enough with create a user under Registered group and add the "Access Administration Access" from the global configuration permissions. From there you can follow the test indication.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39485.}

[viocassel]

I have tested this item ✅ successfully on 9427139

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39485.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39485.}

[roland-d]

Thank you