Skip to content

Conversation

@joomdonation
Copy link
Contributor

Pull Request for Issue #38379.

Summary of Changes

Currently, delete a category does not delete custom fields value associated with that category. This PR just fixes that wrong behavior. See #38379 for detailed issue description.

Testing Instructions

  1. Go to Content -> Fields, create a custom field for category
  2. Go to Content -> Categories, edit a category, look at Fields tab, enter data for the custom field which you created above
  3. Access to your site database (via phpmyadmin for example), look at #__fields_values table, you should see a record contains data for custom field which you entered for category above
  4. Trash the category, then delete the category from the system

Actual result BEFORE applying this Pull Request

The record which store custom fields data for category is not deleted from #__fields_values table

Expected result AFTER applying this Pull Request

The record which store custom fields data for category is deleted from #__fields_values table

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@alikon
Copy link
Contributor

alikon commented Dec 23, 2022

I have tested this item ✅ successfully on 3d72b40


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39477.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 3d72b40


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39477.

@Quy
Copy link
Contributor

Quy commented Dec 23, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39477.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 23, 2022
@wilsonge wilsonge merged commit 6cceeeb into joomla:4.2-dev Dec 28, 2022
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 28, 2022
@wilsonge wilsonge added this to the Joomla! 4.2.7 milestone Dec 28, 2022
@joomdonation joomdonation deleted the fix_delete_category_custom_fields_values branch December 28, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants