Skip to content

Conversation

@joomdonation
Copy link
Contributor

Pull Request for Issue #39468.

Summary of Changes

This PR fixes some deprecated warnings in System - Privacy Consent plugin as described in issue #39468.

Testing Instructions

  1. Enable System - Privacy Consent plugin
  2. Go to System -> Global Configuration, set Error Reporting to Maximum
  3. Login to frontend of your site

Actual result BEFORE applying this Pull Request

You see many deprecated warnings like:

Deprecated: substr(): Passing null to parameter #1 ($string) of type string is deprecated in/home/…/plugins/system/privacyconsent/privacyconsent.php on line 304

Deprecated: substr(): Passing null to parameter #1 ($string) of type string is deprecated in/home/…/plugins/system/privacyconsent/privacyconsent.php on line 305

Deprecated: substr(): Passing null to parameter #1 ($string) of type string is deprecated in/home/…/plugins/system/privacyconsent/privacyconsent.php on line 306

Deprecated: substr(): Passing null to parameter #1 ($string) of type string is deprecated in/home/…/plugins/system/privacyconsent/privacyconsent.php on line 307

Expected result AFTER applying this Pull Request

No warnings anymore.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@chmst
Copy link
Contributor

chmst commented Dec 22, 2022

I have tested this item ✅ successfully on 0335db0

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39475.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 0335db0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39475.

@Quy
Copy link
Contributor

Quy commented Dec 22, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39475.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 22, 2022
@roland-d roland-d merged commit 2b711c6 into joomla:4.2-dev Dec 29, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 29, 2022
@roland-d
Copy link
Contributor

Thank you.

@roland-d roland-d added this to the Joomla! 4.2.7 milestone Dec 29, 2022
@joomdonation joomdonation deleted the fix_deprecated_warnings_in_system_privacy_consent branch February 24, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants