Skip to content

Conversation

@janschoenherr
Copy link
Contributor

This PR fixes the default value for the $language parameter. It makes it equal to Joomla\CMS\Helper\RouteHelper found in libraries/src/Helper/RouteHelper.php.

I am not sure if this is documented somewhere and that documentation would need to be updated.

@chmst
Copy link
Contributor

chmst commented Dec 16, 2022

looks good to me but do you have a test instruction? Had you an error message or warning here?

@janschoenherr
Copy link
Contributor Author

janschoenherr commented Dec 19, 2022

There is no error, it is just phpstan reporting this.

@ceford
Copy link
Contributor

ceford commented Dec 19, 2022

I have tested this item ✅ successfully on 73a9741

Looked at the code and tested the patch. I doubt this would ever show up as a problem. No documentation change required.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39434.

@Quy
Copy link
Contributor

Quy commented Dec 19, 2022

I have tested this item ✅ successfully on 73a9741


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39434.

@Quy
Copy link
Contributor

Quy commented Dec 19, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39434.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 19, 2022
@wilsonge wilsonge merged commit 750679f into joomla:4.2-dev Dec 28, 2022
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 28, 2022
@wilsonge wilsonge added this to the Joomla! 4.2.7 milestone Dec 28, 2022
@janschoenherr janschoenherr deleted the patch-5 branch December 3, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants