Skip to content

Use form.elements instead of custom query #39350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fancyFranci merged 1 commit into from
Feb 3, 2023
Merged

Use form.elements instead of custom query #39350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build/media_source/system/js/fields/validate.es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ class JFormValidator {
const invalid = [];

// Validate form fields
const fields = [].slice.call(form.querySelectorAll('input, textarea, select, button, fieldset'));
const fields = [].slice.call(form.elements);
fields.forEach((field) => {
if (this.validate(field) === false) {
valid = false;
Expand Down Expand Up @@ -284,7 +284,7 @@ class JFormValidator {

attachToForm(form) {
const inputFields = [];
const elements = [].slice.call(form.querySelectorAll('input, textarea, select, button, fieldset'));
const elements = [].slice.call(form.elements);

// Iterate through the form object and attach the validate method to all input fields.
elements.forEach((element) => {
Expand Down