Skip to content

Conversation

@HLeithner
Copy link
Member

@HLeithner HLeithner commented Oct 21, 2022

Replacement PR for #30816 the original author deleted the PR.

Summary of Changes

Add the namespace support to the template manifest file.

Testing Instructions

  • Test existing templates
  • Test existing child template
  • Test copying old templates without namespace
  • Test new dummy template
    • no copy function

Test in Frontend and Backend

Here are some example template to test all 4 variants:
namespacedummy.zip
namespacedummynoparent.zip
nonamespacedummy.zip
nonamespacedummynoparent.zip

Actual result BEFORE applying this Pull Request

No Namespace support for templates

Expected result AFTER applying this Pull Request

Namespace autoloading for templates

Link to documentations

Please select:

@HLeithner HLeithner marked this pull request as ready for review October 23, 2022 10:44
@ReLater
Copy link
Contributor

ReLater commented Nov 29, 2022

I have tested this item ✅ successfully on e047e46

Just BTW: Found this issue during tests. After investigations: Not related with this PR here. #39329


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39011.

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on e047e46


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39011.

@dgrammatiko
Copy link
Contributor

RTC

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39011.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 20, 2022
@bembelimen bembelimen merged commit ca853f2 into joomla:4.3-dev Dec 29, 2022
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 29, 2022
@bembelimen bembelimen added this to the Joomla! 4.3.0 milestone Dec 29, 2022
@HLeithner HLeithner deleted the feature/template-namespace branch June 22, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants