-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add namespace support to templates #39011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bembelimen
merged 8 commits into
joomla:4.3-dev
from
HLeithner:feature/template-namespace
Dec 29, 2022
Merged
Add namespace support to templates #39011
bembelimen
merged 8 commits into
joomla:4.3-dev
from
HLeithner:feature/template-namespace
Dec 29, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
reviewed
Oct 21, 2022
laoneo
approved these changes
Oct 23, 2022
bembelimen
reviewed
Oct 23, 2022
administrator/components/com_templates/src/Model/TemplateModel.php
Outdated
Show resolved
Hide resolved
….php Co-authored-by: Benjamin Trenkle <[email protected]>
4 tasks
Contributor
|
I have tested this item ✅ successfully on e047e46 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39011. |
dgrammatiko
reviewed
Dec 18, 2022
Contributor
|
I have tested this item ✅ successfully on e047e46 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39011. |
Contributor
|
RTC |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39011. |
Contributor
|
Thx |
4 tasks
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement PR for #30816 the original author deleted the PR.
Summary of Changes
Add the namespace support to the template manifest file.
Testing Instructions
Test in Frontend and Backend
Here are some example template to test all 4 variants:
namespacedummy.zip
namespacedummynoparent.zip
nonamespacedummy.zip
nonamespacedummynoparent.zip
Actual result BEFORE applying this Pull Request
No Namespace support for templates
Expected result AFTER applying this Pull Request
Namespace autoloading for templates
Link to documentations
Please select:
Documentation link for docs.joomla.org: Modifying Template, don't know if we have a j4 version of this
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Add template namespace support to Joomla 4.3 Manual#47
No documentation changes for manual.joomla.org needed