Skip to content

Conversation

@brianteeman
Copy link
Contributor

Pull Request for Issue #38952 .

Summary of Changes

Archive Content view does not obey all the article options. Amongst other reasons this is because it was not using the layout

Testing Instructions

Create a new article in a new category
set the article to archive
Create a menu item for archived articles
Test the article options in the menu item to hide/show category, date, details etc

Before

All the optoins work except for the hide article details

After

All works as expected

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@HLeithner HLeithner changed the base branch from 4.2-dev to 4.3-dev October 23, 2022 09:11
@HLeithner HLeithner changed the title [4.2] Archive content Archive content Oct 23, 2022
@HLeithner
Copy link
Member

I rebased this to j4.3 since we try to only have bug fixes in patch releases.

@brianteeman
Copy link
Contributor Author

This is a bug fix. I deliberately submitted this to 4.2 as a bug fix.

@Hackwar Hackwar added the Small A PR which only has a small change label Feb 25, 2023
@brianteeman
Copy link
Contributor Author

array codestyle updated

@Hackwar Hackwar added the bug label Apr 7, 2023
@brianteeman brianteeman changed the title Archive content [4.3] Archive content Apr 21, 2023
@obuisard obuisard added bug and removed bug labels Jul 15, 2023
@Quy
Copy link
Contributor

Quy commented Aug 14, 2023

Installed Blog Sample Data.
Created a Archived Articles menu item.
Go to the frontend.

38953

@brianteeman
Copy link
Contributor Author

@Quy should be fixed now

@Quy
Copy link
Contributor

Quy commented Aug 14, 2023

Before PR:
38953-before

After PR:
38953-after

@brianteeman
Copy link
Contributor Author

good spot @Quy should be fixed now

@Hackwar Hackwar added the PBF Pizza, Bugs and Fun label Aug 25, 2023
@rachelwalraven
Copy link

I have tested this item 🔴 unsuccessfully on a32f990

I could not reproduce the issue. All info was before patch.

Tested in Joomla 4.1 with PHP 8.1.22


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38953.

@TLWebdesign
Copy link
Contributor

@brianteeman i tried to test this but i'm not seeing what option you're talking about that should still be displayed even when toggled to hide. Everything hides even before patch. Am i missing something?

@formfranska
Copy link

I have tested this item ✅ successfully on a32f990


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38953.

1 similar comment
@formfranska
Copy link

I have tested this item ✅ successfully on a32f990


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38953.

@obuisard
Copy link
Contributor

It is a bit confusing to understand, but what I gathered is that you need to have
image
And check if 'Details' is showing or not

@brianteeman brianteeman closed this Sep 8, 2023
@brianteeman brianteeman deleted the archive branch September 8, 2023 12:07
@brianteeman brianteeman restored the archive branch September 24, 2023 07:58
@brianteeman brianteeman reopened this Sep 24, 2023
@HLeithner HLeithner changed the base branch from 4.3-dev to 4.4-dev September 30, 2023 22:44
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 4.4-dev.

@brianteeman brianteeman changed the title [4.3] Archive content [4.4] Archive content Sep 30, 2023
@laoneo laoneo removed the PR-4.3-dev label Oct 2, 2023
@ghost
Copy link

ghost commented Feb 25, 2024

I have tested this item 🔴 unsuccessfully on 373bc12

Using menu item options:

image

Successfully Test:

image

Change option Position of Article Infoto Split give unsuccessfully test:

image

Part of Information shown twice, part isn't shown (like Create Date, Modify Date)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38953.

@Hackwar
Copy link
Member

Hackwar commented Feb 26, 2024

@brianteeman can you have a look at this PR and see if you can get this ready?

@brianteeman
Copy link
Contributor Author

Closing for now as I dont have the available time to look into it

@brianteeman brianteeman deleted the archive branch February 26, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug PBF Pizza, Bugs and Fun PR-4.4-dev Small A PR which only has a small change

Projects

None yet

Development

Successfully merging this pull request may close these issues.