[4.4] PHP8.2 Add missing class properties to views#38939
Merged
laoneo merged 2 commits intojoomla:4.4-devfrom Apr 29, 2023
Merged
[4.4] PHP8.2 Add missing class properties to views#38939laoneo merged 2 commits intojoomla:4.4-devfrom
laoneo merged 2 commits intojoomla:4.4-devfrom
Conversation
bac01b8 to
f818f17
Compare
chmst
reviewed
Jan 10, 2023
administrator/components/com_content/src/View/Articles/HtmlView.php
Outdated
Show resolved
Hide resolved
Contributor
|
I have tested this item ✅ successfully on f818f17 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38939. |
Member
|
I have tested this item ✅ successfully on f818f17 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38939. |
Member
|
@wilsonge can you fix the code style errors? |
Member
|
@wilsonge can you fix the code style issues here? |
683efae to
d3fb5cd
Compare
Contributor
|
I have tested this item ✅ successfully on d3fb5cd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38939. |
laoneo
reviewed
Apr 29, 2023
administrator/components/com_content/src/View/Articles/HtmlView.php
Outdated
Show resolved
Hide resolved
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In several view classes we are missing defining properties of the class that we then use later on in the view causing us to have magic properties. This ensures that they are correctly set in the code base as explicit properties
Testing Instructions
Check tag list, categories, articles list and newsfeed list views and check that they continue to work as before with no changes
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed