Skip to content

[4.4] PHP8.2 Add missing class properties to views#38939

Merged
laoneo merged 2 commits intojoomla:4.4-devfrom
wilsonge:fix/missing-class-propertties
Apr 29, 2023
Merged

[4.4] PHP8.2 Add missing class properties to views#38939
laoneo merged 2 commits intojoomla:4.4-devfrom
wilsonge:fix/missing-class-propertties

Conversation

@wilsonge
Copy link
Contributor

Summary of Changes

In several view classes we are missing defining properties of the class that we then use later on in the view causing us to have magic properties. This ensures that they are correctly set in the code base as explicit properties

Testing Instructions

Check tag list, categories, articles list and newsfeed list views and check that they continue to work as before with no changes

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@chmst
Copy link
Contributor

chmst commented Jan 11, 2023

I have tested this item ✅ successfully on f818f17

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38939.

@laoneo laoneo changed the title Add missing class properties to views [4.2] PHP8.2 Add missing class properties to views Jan 11, 2023
@laoneo laoneo added the PHP 8.x PHP 8.x deprecated issues label Jan 11, 2023
@laoneo laoneo changed the title [4.2] PHP8.2 Add missing class properties to views [4.3] PHP8.2 Add missing class properties to views Jan 11, 2023
@laoneo
Copy link
Member

laoneo commented Jan 11, 2023

I have tested this item ✅ successfully on f818f17

Also code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38939.

@laoneo
Copy link
Member

laoneo commented Jan 12, 2023

@wilsonge can you fix the code style errors?

@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Feb 1, 2023
@Hackwar Hackwar added the bug label Apr 6, 2023
@laoneo laoneo changed the base branch from 4.3-dev to 4.4-dev April 14, 2023 06:03
@laoneo laoneo self-assigned this Apr 14, 2023
@laoneo
Copy link
Member

laoneo commented Apr 14, 2023

@wilsonge can you fix the code style issues here?

@laoneo laoneo removed the PR-4.3-dev label Apr 14, 2023
@laoneo laoneo changed the title [4.3] PHP8.2 Add missing class properties to views [4.4] PHP8.2 Add missing class properties to views Apr 17, 2023
@wilsonge wilsonge force-pushed the fix/missing-class-propertties branch from 683efae to d3fb5cd Compare April 28, 2023 20:52
@alikon
Copy link
Contributor

alikon commented Apr 29, 2023

I have tested this item ✅ successfully on d3fb5cd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38939.

@alikon alikon removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Apr 29, 2023
@laoneo laoneo added this to the Joomla! 4.4.0 milestone Apr 29, 2023
@laoneo laoneo enabled auto-merge (squash) April 29, 2023 10:55
@laoneo laoneo merged commit 3bf9bc7 into joomla:4.4-dev Apr 29, 2023
@laoneo
Copy link
Member

laoneo commented Apr 29, 2023

Thanks!

@wilsonge wilsonge deleted the fix/missing-class-propertties branch June 23, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug PHP 8.x PHP 8.x deprecated issues PR-4.4-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants